linstor: set/unset allow-two-primaries and protocol on rc level #9560
+60
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9560 +/- ##
============================================
- Coverage 12.27% 12.27% -0.01%
+ Complexity 9335 9333 -2
============================================
Files 4699 4699
Lines 414676 414691 +15
Branches 51544 50855 -689
============================================
- Hits 50891 50887 -4
- Misses 357460 357480 +20
+ Partials 6325 6324 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaanHoogland
approved these changes
Aug 22, 2024
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm(, I´d factor out some code to extra methods though, for readability)
c82a92c to
f96aa82
Compare
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 6, 2024
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
Oct 4, 2024
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
Oct 31, 2024
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
Nov 14, 2024
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the way how the linstor plugin sets the correct options to allow live-migration.
Before we set
allow-two-primariesoption on all resources and also don't enable protocol C for that brief time.Now we explicitly set
allow-two-primariesand protocol C on the specific resource connection used andafter the live migration is done those options get removed.
This allows live migration to work if you have set protocol A between 2 datacenters (e.g. DR site).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Live migration in a Linstor cluster with protocol C and A configured between nodes.
How did you try to break this feature and the system with this change?